andretadeu commented on a change in pull request #3: [MWAR-371] Overlays break
first-win rule for web resource with target path ending with '/'
URL: https://github.com/apache/maven-war-plugin/pull/3#discussion_r243771102
##########
File path: src/main/java/org/apache/maven/plugins/war/util/PathSet.java
##########
@@ -113,7 +109,7 @@ public void addAll( Collection<String> paths, String
prefix )
{
for ( String val : paths )
{
- add( prefix + val );
+ add( Paths.get( prefix, val ).toString() );
Review comment:
Another detail:
PathSet class still store the set of paths as String due to serialization /
deserialization to XML. This could not be changed to Set<Path>, otherwise you
will get a StackOverflowError during this process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
