eolivelli commented on a change in pull request #13: MCHECKSTYLE-366 Upgrade 
checkstyle to a more recent version
URL: 
https://github.com/apache/maven-checkstyle-plugin/pull/13#discussion_r277689693
 
 

 ##########
 File path: src/it/MCHECKSTYLE-137/checkstyle.xml
 ##########
 @@ -20,8 +20,6 @@ under the License.
 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.2//EN" 
"http://www.puppycrawl.com/dtds/configuration_1_2.dtd";>
 
 Review comment:
   @romani this file is a test resource, it is an integration test.
   It would be better to create a specific JIRA and track the work to do.
   I will be very happy to fix the problem you are reporting or to help your 
provide a patch.
   This PR has already been merged, we should start a new one

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to