josephw commented on a change in pull request #264: [MNG-6535] Improve test
coverage of UrlNormalizer.
URL: https://github.com/apache/maven/pull/264#discussion_r300662335
##########
File path:
maven-model-builder/src/test/java/org/apache/maven/model/path/DefaultUrlNormalizerTest.java
##########
@@ -82,4 +82,8 @@ public void testPreservationOfDoubleSlashes()
normalize(
"[fetch=]http://server.org/[push=]ssh://server.org/"; ) );
}
+ public void testNormalizeInputWithNoParentDirectoriesToAscendTo()
+ {
+ assertEquals("a/../", normalize("a/../"));
+ }
Review comment:
I'm not sure it's worth changing the behaviour; this class is used with
absolute URLs (or paths), so this is very much an edge case.
However, I think it's (slightly) valuable to test that this case doesn't
cause an error -- perhaps a different test name could make that clear?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
