josephw commented on a change in pull request #264: [MNG-6535] Improve test
coverage of UrlNormalizer.
URL: https://github.com/apache/maven/pull/264#discussion_r300849941
##########
File path:
maven-model-builder/src/test/java/org/apache/maven/model/path/DefaultUrlNormalizerTest.java
##########
@@ -82,4 +82,8 @@ public void testPreservationOfDoubleSlashes()
normalize(
"[fetch=]http://server.org/[push=]ssh://server.org/"; ) );
}
+ public void testNormalizeInputWithNoParentDirectoriesToAscendTo()
+ {
+ assertEquals("a/../", normalize("a/../"));
+ }
Review comment:
Thinking again; there's no reason to retain the existing behaviour if it's
wrong. The change to match `Path` is simple enough, and doesn't break the
existing tests: I've pushed it.
Ideally, the interface would be clearer about its contract, but this is the
least surprising behaviour.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
