[GitHub] [maven-surefire] Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing tests for JUnit5

[GitBox]

Tibor17 commented on issue #245: Surefire-1584: Add option to rerun failing 
tests for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-548552528
 
 
   @Seijan 
   @marcphilipp
   
   I have a trivial test and I have several observations with ParameterizedTest.
   ```
   @ParameterizedTest
   @ValueSource(strings = { "Hello" })
   void test(String world) {
       if (i++ == 0) {
           throw new RuntimeException();
       }
   }
   ```
   
   This `discoveryRequest` does not find our test to run which is this line in 
our code:
   `launcher.execute( discoveryRequest, adapter )`
   It looks like this in debugger. Does it have good values?
   ![](https://gist.github.com/Tibor17/7e5115d4c7ce4b0c1d5bb762ce469e3e)
   
   The ID of the method is this:
   
`[engine:junit-jupiter]/[class:pkg.ParamTest]/[test-template:test(java.lang.String)]/[test-template-invocation:#1]`
   
   Should we filter the method in the request like we do it in JUnit4 and use 
filter the test method `test[1]` instead of `test`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services