[ 
https://issues.apache.org/jira/browse/MRELEASE-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17001904#comment-17001904
 ] 

Elliotte Rusty Harold commented on MRELEASE-946:
------------------------------------------------

Makes sense to me. Would this be compatible with existing workflows?

> pushChanges in release:perform
> ------------------------------
>
>                 Key: MRELEASE-946
>                 URL: https://issues.apache.org/jira/browse/MRELEASE-946
>             Project: Maven Release Plugin
>          Issue Type: Improvement
>            Reporter: James Roper
>            Priority: Minor
>
> It doesn't make sense to me that the tag should be pushed during the prepare 
> stage when using git - pushing the tag is part of publishing the release.  
> Prior to that, you can tag, commit and undo (change history) as much as you 
> want locally, this is the great thing about a distributed SCM, you don't have 
> to push a tag or other changes until the very last minute, which means if 
> there are any problems while preparing, or even performing the release, you 
> can undo it as if it never happened.
> So while prepare does allow you to not push changes, this means that changes 
> have to be pushed manually (or, at least, I haven't seen an option to allow 
> them to be pushed automatically), which to me defeats the purpose of using 
> the release plugin.  I think release:perform should, as a last step, have an 
> option to allow pushing changes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to