bmhm commented on issue #18: [MCHECKSTYLE-381] remove call to 
checker.setClassLoader().
URL: 
https://github.com/apache/maven-checkstyle-plugin/pull/18#issuecomment-569500345
 
 
   @romani @struberg @rfscholte 
   
   Reworked to call the method if it is available by catching a 
`NoSuchMethodError`. I was also thinking of using reflection to check if the 
method exists, but I decided agains this to have minimal changes.
   However, I changed the `urls.toArray()` method to use `new URL[0]` which is 
faster than `new URL[urls.size()]` and also the recommended way on more recent 
versions (Java 8+).
   
   Please review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to