[ https://issues.apache.org/jira/browse/MSHARED-864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Heinz Marbaise updated MSHARED-864: ---------------------------------------- Description: * In the classes {{Maven30DependencyResolver.java}}, {{Maven31DependencyResolver.java}} code can be cleaned up. * Refactoring in {{Invoker.java}} is also possible. The code calls {{setDependencies( List<Dependency> dependencies )}} of {{CollectRequest}} which allows to give {{null}} * {{Invoker}} classes can be simplified. ** Remove not used methods. ** Inlining only locally called methods. ** Move the SuppressWarnings to the invoke methods only; Not in user code (outside of Invoker classes) ** Make code comment requirements to code requirements (number of elements in {{argClasses}} ands {{args}} ** Using generics removes the need of type casts in user code (outside Invoker classes) * Simplify catching exception * {{MavenArtifactDeployer}} interface is not needed to be public. * {{MavenDependencyCollector}} interface is not needed to be public. was: * In the classes {{Maven30DependencyResolver.java}}, {{Maven31DependencyResolver.java}} code can be cleaned up. * Refactoring in {{Invoker.java}} is also possible. The code calls {{setDependencies( List<Dependency> dependencies )}} of {{CollectRequest}} which allows to give {{null}} > Refactor and simplify code > -------------------------- > > Key: MSHARED-864 > URL: https://issues.apache.org/jira/browse/MSHARED-864 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-artifact-transfer > Affects Versions: maven-artifact-transfer-0.13.0 > Reporter: Karl Heinz Marbaise > Assignee: Karl Heinz Marbaise > Priority: Minor > Fix For: maven-artifact-transfer-0.13.0 > > > * In the classes {{Maven30DependencyResolver.java}}, > {{Maven31DependencyResolver.java}} code can be cleaned up. > * Refactoring in {{Invoker.java}} is also possible. > The code calls {{setDependencies( List<Dependency> dependencies )}} of > {{CollectRequest}} which allows to give {{null}} > * {{Invoker}} classes can be simplified. > ** Remove not used methods. > ** Inlining only locally called methods. > ** Move the SuppressWarnings to the invoke methods only; Not in user code > (outside of Invoker classes) > ** Make code comment requirements to code requirements (number of elements in > {{argClasses}} ands {{args}} > ** Using generics removes the need of type casts in user code (outside > Invoker classes) > * Simplify catching exception > * {{MavenArtifactDeployer}} interface is not needed to be public. > * {{MavenDependencyCollector}} interface is not needed to be public. -- This message was sent by Atlassian Jira (v8.3.4#803005)