[ https://issues.apache.org/jira/browse/SUREFIRE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090584#comment-17090584 ]
Tibor Digana commented on SUREFIRE-1262: ---------------------------------------- [~Pavel_K] Regarding 1) it is Surefire and not Failsafe, so the module path must contain classes dir having module-info.class in it. So from my point it is ok. Regarding the 2), maybe you are right but this agrs file was designed by [~rfscholte] so I would like to hear his reasons why we simply did not put all libraries to the module path. [~rfscholte] pls see the points 1) and 2) as a reference in https://issues.apache.org/jira/browse/SUREFIRE-1262?focusedCommentId=17090549&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17090549 > Add modulepath support > ---------------------- > > Key: SUREFIRE-1262 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1262 > Project: Maven Surefire > Issue Type: Improvement > Reporter: Robert Scholte > Assignee: Tibor Digana > Priority: Major > Fix For: 2.21.0 > > > With the Jigsaw project Java9 is extended with a modulepath. This means that > surefire should be executed in a different way. > When working with a modulepath, the Classpath in the MANIFEST of the > executable jar will be ignored, you need need to add everything on > commandline. > Just like javadoc, the java executable has an {{@<file>}} option, where you > can add arguments per line. So this is the new preferred way to build the > module-path. > IIUC for surefire it is important to add {{--patch-module > target/test-classes}} (was: -Xpatch) which makes it possible to use the same > packages as target/classes. -- This message was sent by Atlassian Jira (v8.3.4#803005)