[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #289: SUREFIRE-1784 Fork JVM defined by jvm param should not inherit JAVA_HOME from Maven process

[GitBox]

Tibor17 commented on a change in pull request #289:
URL: https://github.com/apache/maven-surefire/pull/289#discussion_r416878759



##########
File path: 
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoTest.java
##########
@@ -2183,6 +2183,13 @@ public void setToolchain( Toolchain toolchain ) throws 
Exception
             toolchainField.setAccessible( true );
             toolchainField.set( this, toolchain );
         }
+
+        public void setJvm( String jvm ) throws Exception
+        {
+            Field toolchainField = 
AbstractSurefireMojo.class.getDeclaredField( "jvm" );

Review comment:
       pls substitute these three lines with `setInternalState( this, "jvm", 
jvm );`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org