bguerin commented on a change in pull request #56: URL: https://github.com/apache/maven-release/pull/56#discussion_r428857571
########## File path: maven-release-manager/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptorBuilder.java ########## @@ -58,7 +59,9 @@ public ReleaseDescriptorBuilder addCheckModificationExclude( String string ) public ReleaseDescriptorBuilder setActivateProfiles( List<String> profiles ) { - releaseDescriptor.setActivateProfiles( profiles ); + List<String> copy = new ArrayList<>(); + copy.addAll( profiles ); Review comment: > ReleaseUtils during property copy overrides any existing value of the builder. The builder does not have getter...so we can not merge neither in ReleaseUtil neither in DefaultReleaseManager so what should be done Yep, this is it > ReleaseUtil must have the knowlegde that profiles are gathered from many parts so it should handle the copy like a merge I can't find history of my previous PR anymore, but if I am right, this is what I start to do, and Robert said he prefered to see this specific code in DefaultReleaseManager ... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org