elharo commented on pull request #15: URL: https://github.com/apache/maven-ear-plugin/pull/15#issuecomment-702025531
Sounds plausible. Can you open an issue in the Jira and assign to me? On Thu, Oct 1, 2020 at 8:45 AM Mikhail Gavrilov <notificati...@github.com> wrote: > *@zzzLobster* commented on this pull request. > ------------------------------ > > In src/main/java/org/apache/maven/plugins/ear/EarMojo.java > <https://github.com/apache/maven-ear-plugin/pull/15#discussion_r498081406> > : > > > @@ -453,7 +453,10 @@ private void copyModules( final JavaEEVersion javaEEVersion, > { > getLog().info( "Copying artifact [" + module + "] to [" + module.getUri() + "] (unpacked)" ); > // Make sure that the destination is a directory to avoid plexus nasty stuff :) > - destinationFile.mkdirs(); > + if ( !destinationFile.mkdirs() ) > > This change seems to be causing an issue when build is run without "clean". > [INFO] Copying artifact [ejb:com.aaa.bbb:bbb-ejb:1.0.0.0-SNAPSHOT] to > [bbb-ejb.jar] > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-ear-plugin:3.1.0:ear (default-ear) on > project bbb-ear: Failed to create directory > /Checkout/project/bbb/bbb-ear/target/temp/bbb-ejb.jar -> [Help 1] > > Probably it should be wrapped with something like: > > if ( !destinationFile.isDirectory() ) > { > if ( !destinationFile.mkdirs() ) > { > throw new MojoExecutionException( "Error creating " + destinationFile ); > } > } > > — > You are receiving this because you modified the open/close state. > Reply to this email directly, view it on GitHub > <https://github.com/apache/maven-ear-plugin/pull/15#pullrequestreview-500131735>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAHVP2BRCHY6LCADKNCI4BTSIQ6RLANCNFSM4RZSOHKA> > . > -- Elliotte Rusty Harold elh...@macfaq.com ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
