elharo commented on a change in pull request #35:
URL: https://github.com/apache/maven-doxia/pull/35#discussion_r501060691
##########
File path:
doxia-core/src/main/java/org/apache/maven/doxia/parser/Xhtml5BaseParser.java
##########
@@ -81,14 +81,14 @@
/** {@inheritDoc} */
@Override
- public void parse( Reader source, Sink sink )
+ public void parse( Reader source, Sink sink, String reference )
Review comment:
It's hard to follow from the diff, but are any of the apparent method
signature changes real? Or is it just Github diff being funky?
If these are real changes is it possible to add overloads with the old
variants that pass null for reference?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
