[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #19: [MEAR-267] - Fixed detection if JAR module is included into classpath of particular EAR module manifest

[GitBox]

mabrarov commented on a change in pull request #19:
URL: https://github.com/apache/maven-ear-plugin/pull/19#discussion_r501128499



##########
File path: 
src/test/java/org/apache/maven/plugins/ear/it/AbstractEarPluginIT.java
##########
@@ -119,61 +128,72 @@ protected File executeMojo( final String projectName, 
final Properties propertie
     protected File executeMojo( final String projectName, final Properties 
properties )
         throws VerificationException, IOException
     {
-        return executeMojo( projectName, properties, true );
+        return executeMojo( projectName, properties, true, true );
     }
 
     /**
-     * Executes the specified projects and asserts the given artifacts. Assert 
the deployment descriptors are valid
-     * 
+     * Executes the specified projects and asserts the given artifacts. 
Asserts the deployment descriptors are valid.
+     * Asserts Class-Path entry of manifest of EAR modules.
+     *
      * @param projectName the project to test
+     * @param earModuleName the name of 1st level EAR module in multi-module 
project or null if project is single-module
      * @param expectedArtifacts the list of artifacts to be found in the EAR 
archive
      * @param artifactsDirectory whether the artifact is an exploded 
artifactsDirectory or not
+     * @param moduleArtifacts the list of artifacts representing EAR modules 
which manifest needs to be asserted or

Review comment:
       Rephrased in 97bd177 (includes renaming of parameters too)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org