[ 
https://issues.apache.org/jira/browse/MCOMPILER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215505#comment-17215505
 ] 

Gili commented on MCOMPILER-436:
--------------------------------

Looking at 
https://github.com/codehaus-plexus/plexus-languages/blob/master/plexus-java/src/main/java/org/codehaus/plexus/languages/java/jpms/LocationManager.java
 it seems that the module name *can* be extracted. The problem is that 
LocationManager.resolvePaths() does a lot more than extracting the module name. 
It tries resolving all line entries inside module-info.java.

If we were to tease apart the different functionality, what would happen? Would 
we get past the module name extraction but at runtime the JRE would fail with a 
module load error? From a user perspective I think this would be a much nicer 
experience. I just don't know how much extra work will be involved to make this 
happen.

> Cannot compile code that depends on on Apache Mina SSH due to JPMS error
> ------------------------------------------------------------------------
>
>                 Key: MCOMPILER-436
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-436
>             Project: Maven Compiler Plugin
>          Issue Type: Bug
>    Affects Versions: 3.8.1
>            Reporter: Gili
>            Priority: Major
>         Attachments: extract-module-name.zip
>
>
> 1. Extract Testcase
> 2. Run "mvn clean install"
> 3. Build fails with:
> [WARNING] Can't extract module name from sshd-core-2.5.1.jar: Provider class 
> org.apache.sshd.common.file.root.RootedFileSystemProvider not in module
> [ERROR] module not found: sshd.core
> Expected behavior: The plugin should be able to extract the module name given 
> that sshd-core depends on sshd-commons which contains the aforementioned 
> provider and automatic modules can access classes outside their module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to