elharo commented on a change in pull request #34:
URL:
https://github.com/apache/maven-compiler-plugin/pull/34#discussion_r514368549
##########
File path:
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
##########
@@ -483,7 +483,19 @@
private List<String> fileExtensions;
/**
- * to enable/disable incrementation compilation feature
+ * <p>to enable/disable incrementation compilation feature.</p>
+ * <p>This leads to two different modes depending on the underlining
compiler. Default javac compiler does the
+ * following:</p>
+ * <ul>
+ * <li>true <strong>(default)</strong> in this mode the compiler plugin
determines whether any JAR files the
+ * current module depends on have been changed in the current build run,
or any source file was added, removed or
+ * changed since the last compilation. If this is the case, the compiler
plugin recompiles all sources</li>
Review comment:
period at end
##########
File path:
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
##########
@@ -483,7 +483,19 @@
private List<String> fileExtensions;
/**
- * to enable/disable incrementation compilation feature
+ * <p>to enable/disable incrementation compilation feature.</p>
+ * <p>This leads to two different modes depending on the underlining
compiler. Default javac compiler does the
+ * following:</p>
+ * <ul>
+ * <li>true <strong>(default)</strong> in this mode the compiler plugin
determines whether any JAR files the
+ * current module depends on have been changed in the current build run,
or any source file was added, removed or
+ * changed since the last compilation. If this is the case, the compiler
plugin recompiles all sources</li>
+ * <li>false <strong>(not recommended)</strong> this only compiles source
files which are newer than their
+ * corresponding class files. That is which have been changed since the
last compilation. This does not
Review comment:
That is...
is a sentence fragment
##########
File path:
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
##########
@@ -483,7 +483,19 @@
private List<String> fileExtensions;
/**
- * to enable/disable incrementation compilation feature
+ * <p>to enable/disable incrementation compilation feature.</p>
+ * <p>This leads to two different modes depending on the underlining
compiler. Default javac compiler does the
Review comment:
underlining --> underlying
The default javac
##########
File path:
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
##########
@@ -483,7 +483,19 @@
private List<String> fileExtensions;
/**
- * to enable/disable incrementation compilation feature
+ * <p>to enable/disable incrementation compilation feature.</p>
+ * <p>This leads to two different modes depending on the underlining
compiler. Default javac compiler does the
+ * following:</p>
+ * <ul>
+ * <li>true <strong>(default)</strong> in this mode the compiler plugin
determines whether any JAR files the
+ * current module depends on have been changed in the current build run,
or any source file was added, removed or
Review comment:
have been --> have
build run, --> build run;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
