mabrarov edited a comment on pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-727563337
@ rfscholte, Regarding [your qustion](/apache/maven-ear-plugin/pull/24#pullrequestreview-530790385). > there will be a request to select per module which artifacts should be moved to the (shared) lib directory. Do you mean "select skinny mode (move all or nothing) per module and not for all modules"? If yes, then here are my thoughts: I thought about the same but then decided that `skinnyWars` option doesn't provide such ability so that `skinnyModules` option can follow the same approach. > Would such a change fit in this PR without adjusting the new parameters? We can add both: 1. `skinnyModules` option of plugin configuration (implemented) 1. `skinny` property of EAR module which default value is equal to `skinnyModules` option of plugin configuration (`skinnyModules || skinnyWars` for web module). That way we can use global configuration and perform fine tuning when required. But I'm not sure if this feature is really wanted by users of Maven EAR Plugin... I never had a need: 1. to move into shared EAR lib directory just a part of EAR module libraries 1. to make some modules of EAR skinny while other - non-skinny. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
