michael-o commented on pull request #119:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/119#issuecomment-751395195


   > 
   > 
   > I noticed this:
   > 
   > ```
   >     /**
   >      * Attach the classpath file to the main artifact so it can be 
installed and deployed.
   >      *
   >      * @since 2.0
   >      */
   >     @Parameter( defaultValue = "false" )
   >     private boolean attach;
   > ```
   > 
   > If the classpath file we're building here is going out to Maven 
repositories, it really shouldn't use the platform encoding. What's the purpose 
of this file? Is there a spec for it somewhere that might indicate which 
encoding should be used?
   
   Stick to the MSITE approach. If not defined, use UTF-8.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to