michael-o commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549106505



##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
       </properties>
     </profile>
     -->
+    <profile>
+      <activation>
+        <activeByDefault>true</activeByDefault>

Review comment:
       I was never a fan of implicit deactivation because it seems to much 
magic to me. My initial idea was to name the profile. Same approach I have used 
with Maven Resolver Redisson Sync Context. I want to reserve a URN-style id 
namespace to use. In Resolver I have used: `maven:resolver:` prefix. Here I 
would like to use `maven:core:central-repo`, at least the `maven:core:` prefix.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to