bmarwell commented on pull request #415: URL: https://github.com/apache/maven/pull/415#issuecomment-751754398
> This looks OK, but incomplete. When if you at `org.apache.maven.cli.MavenCli.logging(CliRequest)` in the block marked with `// LOG COLOR` you see duplicate code now. It is probably time to move that code out of `logging()` into `cli()`. > > I wonder what will happen when one does the following: > > ``` > mvn -v -Dstyle.color=always | less -R > ``` > > I would expect to see colors here also stdout is not attached to a tty. I think we need to move the use property to a CLI option to make it more obvious. > > I am quite used to: `grep --color=always ... | less -R` Which one? This? https://github.com/apache/maven/blob/496b9bd65d0ddd0fb19c8c9f89058555f458790e/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L508-L522 I do not see this code duplicated somewhere else. There are other duplicated parts, however.  ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
