[GitHub] [maven] bmarwell commented on a change in pull request #415: [MNG-7032] do not print colours for --version when in batch mode.

[GitBox]

bmarwell commented on a change in pull request #415:
URL: https://github.com/apache/maven/pull/415#discussion_r549097062



##########
File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
##########
@@ -433,6 +433,8 @@ void cli( CliRequest cliRequest )
 
         if ( cliRequest.commandLine.hasOption( CLIManager.VERSION ) )
         {
+            // MNG-7032: Also disable colours if in batch mode

Review comment:
       Hi @michael-o – are you sure it is "unwanted"? There are numerous 
similar comments…
   
   Also, I think it is helpful for readability. You do not always have all 
commits on your second screen. Blame might not help if there was a slight 
change in a later version, as blame only shows the LATEST commit of a line.
   
   
![2020-12-27T11:46:22_0001_screenshot](https://user-images.githubusercontent.com/1413391/103169106-47362a80-4839-11eb-9a62-ee0ec7f35be9.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org