rmannibucau commented on a change in pull request #438:
URL: https://github.com/apache/maven/pull/438#discussion_r564557392
##########
File path: maven-plugin-api/pom.xml
##########
@@ -54,6 +54,11 @@ under the License.
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-classworlds</artifactId>
</dependency>
+ <dependency>
Review comment:
Well for the last part mockito does way more than a custom impl and half
of it is not desired I guess for such tests (mainly cause of maintenance).
On the logger impl I meant DefaultLog impl whatever is under (if it moves to
something else than plexus and uses a slf4j particular binding it would be the
kind of same comment).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
