Tibor17 commented on a change in pull request #333:
URL: https://github.com/apache/maven-surefire/pull/333#discussion_r566089270
##########
File path:
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java
##########
@@ -139,6 +139,12 @@
@Parameter( property = "failIfNoTests" )
private Boolean failIfNoTests;
+ /**
+ * The number of flakes after which the overall test suite will be
considered a failure.
+ */
+ @Parameter( property = "surefire.failOnFlakeCount", defaultValue = "0" )
+ private int failOnFlakeCount;
Review comment:
Exactly this was not clear to me either when we spoke with the JUnit5
colleagues several days ago.
The logic of `re-run` feature operates at the level of individual Test.
In this PR I guess we are talking about the level of Test Set (cumulative
number of flakes) which is different view from ours. But's that's ok if it
would be properly clarified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
