[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #333: Add failOnFlakeCount option

[GitBox]

Tibor17 commented on a change in pull request #333:
URL: https://github.com/apache/maven-surefire/pull/333#discussion_r568178204



##########
File path: 
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java
##########
@@ -236,6 +243,11 @@ protected boolean verifyParameters()
             return false;
         }
 
+        if ( failOnFlakeCount < 0 )

Review comment:
       This must be in the abstract class where are all the warning check 
method calls made in the section:
   ```
           else
           {
               ensureEnableProcessChecker();
               convertDeprecatedForkMode();
               ensureWorkingDirectoryExists();
               ensureParallelRunningCompatibility();
               ensureThreadCountWithPerThread();
               warnIfUselessUseSystemClassLoaderParameter();
               warnIfDefunctGroupsCombinations();
               warnIfRerunClashes();
               warnIfWrongShutdownValue();
               warnIfNotApplicableSkipAfterFailureCount();
               warnIfIllegalTempDir();
               warnIfForkCountIsZero();
               printDefaultSeedIfNecessary();
           }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org