Tibor17 commented on a change in pull request #333:
URL: https://github.com/apache/maven-surefire/pull/333#discussion_r569070727
##########
File path:
maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java
##########
@@ -880,4 +900,20 @@ protected final ForkNodeFactory getForkNode()
{
return forkNode;
}
+
+ @Override
+ boolean verifyParameters() throws MojoFailureException,
MojoExecutionException
Review comment:
>
>
> But why would the super class contain logic that only applies to a single
subclass?
Both plugins, Surefire and Failsafe, have 90% same parameters. So they
always contained the method `verifyParameters()` in the super class. The
`VerifyMojo` is an exception and it has never had so many config params.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
