[
https://issues.apache.org/jira/browse/MNG-7052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280647#comment-17280647
]
Martin Kanters commented on MNG-7052:
-------------------------------------
[~tibordigana] This decision was taken together with [~rfscholte] and
[~mthmulders] almost two months ago I believe, so my memory might be a bit
foggy. As far as I remember IDs in the POM are usually checked against the
regex shown in the issue description, but the profile ID was never checked.
This needed to be made consistent. I don't necessarily think the + sign should
be a problem, as long as it is not the first characters. ('+' is currently the
opposite character from the '-' character, which can be used to unselect
profiles or projects).
Personally I don't know whether the + can or should be added to the list.
Perhaps Robert or Michael can give their take on this. I'm not sure what the
impact could be.
> Do not allow symbols as first character of identifiers in the POM
> -----------------------------------------------------------------
>
> Key: MNG-7052
> URL: https://issues.apache.org/jira/browse/MNG-7052
> Project: Maven
> Issue Type: Improvement
> Components: core
> Reporter: Martin Kanters
> Priority: Major
> Labels: up-for-grabs
> Fix For: 4.0.x-candidate
>
>
> In the {{DefaultModelValidator}} we currently validate identifiers against
> {{a-zA-Z0-9-_.}}
> Since Maven also allows operators to be used against an identifier, this can
> result in bugs or at least unexpected behavior for the user.
> The minus operator can be used to deactivate a certain profile, so an example
> would be:
> - A project having a profile with the id {{-id-of-profile}}
> - A Maven invocation of {{mvn <goal> -P-id-of-profile}}.
> The release of Maven 4 is a nice opportunity to restrict the first character
> of an id to be {{a-zA-Z0-9}} . The other characters may still consist of
> those symbols.
> This should apply to all identifiers that we support. The methods that need
> attention are:
> {{DefaultModelValidator#validateId}} and
> {{DefaultModelValidator#validateIdWithWildcards}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
