[ 
https://issues.apache.org/jira/browse/MNG-7052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280678#comment-17280678
 ] 

Michael Osipov commented on MNG-7052:
-------------------------------------

Items in question:
{noformat}
osipovmi@deblndw011x:~/var/Projekte/maven (revert-MNG-6772=)
$ grep -n '>id<' ./maven-settings/src/main/mdo/settings.mdo 
./maven-model/src/main/mdo/maven.mdo
# IdentifiableBase: Mirror, Profile, Proxy, Server
./maven-settings/src/main/mdo/settings.mdo:97:          <name>id</name>
# RepositoryBase: Repository
./maven-settings/src/main/mdo/settings.mdo:813:          <name>id</name>
# Developer
./maven-model/src/main/mdo/maven.mdo:1176:          <name>id</name>
# RepositoryBase: Repository
./maven-model/src/main/mdo/maven.mdo:1869:          <name>id</name>
# Site
./maven-model/src/main/mdo/maven.mdo:2037:          <name>id</name>
# PluginExecution
./maven-model/src/main/mdo/maven.mdo:2381:          <name>id</name>
# Profile
./maven-model/src/main/mdo/maven.mdo:2561:          <name>id</name>
# ReportSet
./maven-model/src/main/mdo/maven.mdo:2921:          <name>id</name>
{noformat}


> Do not allow symbols as first character of identifiers in the POM
> -----------------------------------------------------------------
>
>                 Key: MNG-7052
>                 URL: https://issues.apache.org/jira/browse/MNG-7052
>             Project: Maven
>          Issue Type: Improvement
>          Components: core
>            Reporter: Martin Kanters
>            Priority: Major
>              Labels: up-for-grabs
>             Fix For: 4.0.x-candidate
>
>
> In the {{DefaultModelValidator}} we currently validate identifiers against 
> {{a-zA-Z0-9-_.}} 
> Since Maven also allows operators to be used against an identifier, this can 
> result in bugs or at least unexpected behavior for the user.
> The minus operator can be used to deactivate a certain profile, so an example 
> would be:
> - A project having a profile with the id {{-id-of-profile}}
> - A Maven invocation of {{mvn <goal> -P-id-of-profile}}.
> The release of Maven 4 is a nice opportunity to restrict the first character 
> of an id to be {{a-zA-Z0-9}} . The other characters may still consist of 
> those symbols.
> This should apply to all identifiers that we support. The methods that need 
> attention are:
> {{DefaultModelValidator#validateId}} and 
> {{DefaultModelValidator#validateIdWithWildcards}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to