MartinKanters commented on a change in pull request #444:
URL: https://github.com/apache/maven/pull/444#discussion_r575239494
##########
File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
##########
@@ -1032,20 +1031,6 @@ private int execute( CliRequest cliRequest )
{
logBuildResumeHint( "mvn <args> -r" );
}
- else if ( !failedProjects.isEmpty() )
Review comment:
It would indeed be a very exceptional case, but it's possible that
writing the resume.properties file on disk fails for some reason. That's why we
kept it.
This piece of code ensures that in that event, the canResume flag is not set
to `true`, so it would end up in logging the `-rf` hint.
https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/DefaultMaven.java#L404-L412
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
