[ 
https://issues.apache.org/jira/browse/MENFORCER-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17289544#comment-17289544
 ] 

Jeffrey Bennett commented on MENFORCER-376:
-------------------------------------------

The normal case for both an include and exclude being present would be
something like include-a-directory but exclude-file-in-directory.  In that
scenario, include and exclude make sense as they operate like an
all-but-this-one complement to each other.

That said, such a scenario does not exist here.  The vendors listed are
specific ones.

In short, should be either includes or excludes but not both.  If you have
either an include, or an exclude, or neither, it's
pretty straight forward.


On Sun, Jan 24, 2021, 9:45 AM Krosheninnikov Artem (Jira) <j...@apache.org>



> Add support for excludes/includes in requireJavaVendor rule
> -----------------------------------------------------------
>
>                 Key: MENFORCER-376
>                 URL: https://issues.apache.org/jira/browse/MENFORCER-376
>             Project: Maven Enforcer Plugin
>          Issue Type: Improvement
>          Components: Standard Rules
>    Affects Versions: 3.0.0-M3
>            Reporter: Krosheninnikov Artem
>            Priority: Major
>
> There was a suggestion here [1] to add includes/excludes support in 
> requireJavaVendor rule. Right now it's not clear how it would work if you 
> define the same vendor name in exclude and include lists but implementation 
> can be more or less copied from BannedDependencies rule.
> [1] 
> https://issues.apache.org/jira/browse/MENFORCER-338?focusedCommentId=17169044&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17169044



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to