mkarg commented on pull request #90:
URL: https://github.com/apache/maven-shade-plugin/pull/90#issuecomment-826113453


   > No commandline argument should have impact on the outcome of the artifact.
   
   That is just a personal opinion; others think differently and nobody besides 
you had a problem so far with it (they all approved without requesting a 
change). The compiler plugin supports e. g. `-Dmaven.main.skip`, and it clearly 
*has* an impact on the outcome of the artifact and nobody requested a change to 
remove it.  
   
   > @mkarg it solves your use case more cleanly since you intentionally enable 
to skip it because your project can so guess it is not a bad compromise: enable 
without breaking other cases by default, more "maven spirit" ;).
   
   In fact it is *not* intentionally and I don't want to "plan upfront" the use 
of it: I need to skip *just once* to see if the problem comes from the shading 
plugin or not. I don't want to have to prepare the POM of all my projects "just 
in case" I need it *just once* some day (which is the most common case for me 
to skip shading).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to