elharo commented on a change in pull request #18:
URL:
https://github.com/apache/maven-common-artifact-filters/pull/18#discussion_r624676196
##########
File path: pom.xml
##########
@@ -108,11 +114,23 @@
<groupId>org.apache.maven</groupId>
<artifactId>maven-core</artifactId>
<version>${maven.version}</version>
+ <exclusions>
Review comment:
We are not trying to make sure there is no plexus in the classpath. We
are trying to make sure this plugin does not introduce a dependency on plexus,
but this plugin should not attempt to control the dependencies of its own
dependencies. Doing so like this risks breaking them in confusing and
hard-to-debug ways. If one of this plugin's dependencies introduces plexus,
then that needs to be addressed in that dependency, not here.
Exclusions are risky and confusing. They should be reserved only for very
well defined and understood conflicts, most often because two different
artifacts are otherwise supplying the same classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
