[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375475#comment-17375475
 ] 

Piotr Zygielo commented on MCHECKSTYLE-406:
-------------------------------------------

{quote}As for the Mojohaus parent plugin config, those path names are not doing 
anything in AspectJ Maven, because the files simply do not exist. They are not 
mandatory.
{quote}
As I've already said:
{quote}[DEBUG] The resource 'config/maven_checks.xml' was found as 
jar:[file:.../m2/repository/org/apache/maven/shared/maven-shared-resources/3/maven-shared-resources-3.jar!/config/maven_checks.xml|file:///.../m2/repository/org/apache/maven/shared/maven-shared-resources/3/maven-shared-resources-3.jar!/config/maven_checks.xml].
{quote}
It comes from the build of aspectj-maven-plugin that failing build was linked 
in original description. So I'm not sure what couldĀ _those path names are not 
doing anything_ mean, as they are clearly doing something and are used. 
Otherwise - what CS configuration do you think a-m-p uses then?

[https://github.com/dev-aspectj/aspectj-maven-plugin/pull/20] links to CS RN, 
and the [https://checkstyle.org/releasenotes.html#Release_8.42] clearly 
enumerates *Breaking backward compatibility.*
{quote}I am using the latest versions of everything in my POM, according to 
Dependabot, so 
{quote}
It's not enough. I am not a bot, but according to me, a-m-p uses CS config that 
is not compatible with newer CS, and if a-m-p desires to update CS, CS's config 
shall be updated as well.
{quote}I am not sure what I should upgrade.
{quote}
Already said: _aspectj-maven-plugin is overriding this dependency - IMO it 
shall also be responsible for providing proper, up to date, CS configuration._

> Make plugin compatible with Checkstyle 8.44
> -------------------------------------------
>
>                 Key: MCHECKSTYLE-406
>                 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-406
>             Project: Maven Checkstyle Plugin
>          Issue Type: Dependency upgrade
>    Affects Versions: 3.1.2
>            Reporter: Alexander Kriegisch
>            Priority: Major
>
> On GitHub, Dependabot suggests upgrading Checkstyle to something more recent 
> than 8.41.1, but the corresponding builds fail, both for 8.43 and 8.44, e.g. 
> [this 
> build|https://github.com/dev-aspectj/aspectj-maven-plugin/pull/20/checks?check_run_id=2933248023]:
> {code}
> Error:  Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:3.9.1:site (default-site) on 
> project aspectj-maven-plugin: Error generating 
> maven-checkstyle-plugin:3.1.2:checkstyle report: Failed during checkstyle 
> configuration: cannot initialize module TreeWalker - cannot initialize module 
> JavadocMethod - Property 'scope' does not exist, please check the 
> documentation -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-site-plugin:3.9.1:site (default-site) on 
> project aspectj-maven-plugin: Error generating 
> maven-checkstyle-plugin:3.1.2:checkstyle report
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:215)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
>     (...)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error generating 
> maven-checkstyle-plugin:3.1.2:checkstyle report
>     at org.apache.maven.plugins.site.render.SiteMojo.execute 
> (SiteMojo.java:151)
>     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
>     (...)
> Caused by: org.apache.maven.reporting.MavenReportException: Failed during 
> checkstyle configuration
>     at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure 
> (AutomaticBean.java:201)
>     at 
> org.apache.maven.plugins.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle
>  (DefaultCheckstyleExecutor.java:167)
>     at 
> org.apache.maven.plugins.checkstyle.AbstractCheckstyleReport.executeReport 
> (AbstractCheckstyleReport.java:533)
>     (...)
> {code}
> This is in no way urgent, but as Dependabot keeps bugging me with this for 
> every new Checkstyle version, I thought I should mention it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to