mbenson commented on a change in pull request #64:
URL: https://github.com/apache/maven-archetype/pull/64#discussion_r665437580
##########
File path:
maven-archetype-plugin/src/main/java/org/apache/maven/archetype/ui/generation/DefaultArchetypeGenerationConfigurator.java
##########
@@ -313,46 +308,24 @@ else if (
!archetypeGenerationQueryer.confirmConfiguration( archetypeConfigurati
request.setProperties( properties );
}
- private String getTransitiveDefaultValue( String defaultValue,
ArchetypeConfiguration archetypeConfiguration,
- String requiredProperty, Context
context )
+ private static String expandEmbeddedTemplateExpressions( String
originalText, String textDescription, Context context )
{
- String result = defaultValue;
- if ( null == result )
+ if ( StringUtils.contains( originalText, "${" ) )
Review comment:
`null` safety
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
