rfscholte commented on a change in pull request #488:
URL: https://github.com/apache/maven/pull/488#discussion_r672971833
##########
File path: maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java
##########
@@ -223,6 +224,7 @@ public void
testMVNConfigurationThreadCanBeOverwrittenViaCommandLine()
* <pre>
* -T 3
* -Drevision=1.3.0
+ * -Dlabel=Apache Maven
Review comment:
see previous comment
##########
File path: maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java
##########
@@ -279,6 +282,7 @@ public void
testMVNConfigurationCLIRepeatedPropertiesLastWins()
* <pre>
* -T 3
* -Drevision=1.3.0
+ * -Dlabel=Apache Maven
Review comment:
see previous comment
##########
File path: maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java
##########
@@ -251,6 +253,7 @@ public void
testMVNConfigurationDefinedPropertiesCanBeOverwrittenViaCommandLine(
* <pre>
* -T 3
* -Drevision=1.3.0
+ * -Dlabel=Apache Maven
Review comment:
see previous comment
##########
File path: maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java
##########
@@ -197,6 +197,7 @@ public void testMavenConfigInvalid()
* <pre>
* -T 3
* -Drevision=1.3.0
+ * -Dlabel=Apache Maven
Review comment:
I propose to use `-Dlabel="Apache Maven"` or `"-Dlabel=Apache Maven"`,
as you would never be able to use `-Dlabel=Apache Maven` from commandline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
