rfscholte commented on a change in pull request #489:
URL: https://github.com/apache/maven/pull/489#discussion_r672609882
##########
File path:
maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java
##########
@@ -70,7 +70,7 @@
implements ModelValidator
{
- private static final Pattern CI_FRIENDLY_EXPRESSION = Pattern.compile(
"\\$\\{(.+?)\\}" );
+ private static final Pattern EXPRESSION_NAME = Pattern.compile(
"\\$\\{(.+?)\\}" );
Review comment:
The first group is the expression name, which is always the thing you're
interested in.
##########
File path:
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##########
@@ -814,7 +814,7 @@ private Model readRawModel( ModelBuildingRequest request,
DefaultModelProblemCol
}
catch ( IOException e )
{
- problems.add( new ModelProblemCollectorRequest(
Severity.FATAL, Version.V37 ).setException( e ) );
Review comment:
It shouldn't. If it is, it should be replaced with `40`
##########
File path:
maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java
##########
@@ -70,7 +70,7 @@
implements ModelValidator
{
- private static final Pattern CI_FRIENDLY_EXPRESSION = Pattern.compile(
"\\$\\{(.+?)\\}" );
+ private static final Pattern EXPRESSION_NAME = Pattern.compile(
"\\$\\{(.+?)\\}" );
Review comment:
It was only used for CI-friendly expressions. I noticed I needed exactly
the same regexp, hence had to rename it.
##########
File path:
maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java
##########
@@ -70,7 +70,7 @@
implements ModelValidator
{
- private static final Pattern CI_FRIENDLY_EXPRESSION = Pattern.compile(
"\\$\\{(.+?)\\}" );
+ private static final Pattern EXPRESSION_NAME = Pattern.compile(
"\\$\\{(.+?)\\}" );
Review comment:
`EXPRESSION_NAME_PATTERN` is fine by me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
