kriegaex commented on pull request #110:
URL: 
https://github.com/apache/maven-shade-plugin/pull/110#issuecomment-884708342


   @JanMosigItemis, would you mind if I squashed your commits (and my early one 
too)? The original workaround incl. unit test is no longer necessary, nor is my 
refactoring of it. Only a little bit of structural test refactoring is left 
over.
   
   @rmannibucau, I can squash your "basic dir handling in default shader" 
commit too, but also try to retain it, even though Tibor is not going to like 
it and probably going to squash before the merge anyway. Please also be so kind 
as to review this PR. I think it is as far as we should go before the next 
major release, for which you are planning more general refactoring. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to