jmhodges commented on pull request #646: URL: https://github.com/apache/maven/pull/646#issuecomment-1002800043
(I deleted a comment I wrote because I hadn't seen all the commentary) Thanks for the feedback! Totally agreed on upstreaming this. I'm making a ticket for them I do think adding to `.gitignore` is still useful. Adding to `.gitignore` turns out to be the only change we need to convince rat to not alarm, makes sure reviewers aren't having to waste cycles ensuring that `.vscode` doesn't get accidentally added to git, and avoids contributors having to make global changes to their config to get a working build. I've updated the PR to only touch `.gitignore`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
