cstamas commented on a change in pull request #8:
URL: https://github.com/apache/maven-reporting-exec/pull/8#discussion_r791408235
##########
File path: pom.xml
##########
@@ -56,9 +56,9 @@
</distributionManagement>
<properties>
- <mavenVersion>3.0</mavenVersion>
+ <mavenVersion>3.2.5</mavenVersion>
+ <aetherVersion>1.0.0.v20140518</aetherVersion>
Review comment:
Whenever "maven version" in play, I tend to align resolver based on this
table:
https://cwiki.apache.org/confluence/display/MAVEN/Maven+Ecosystem+Cleanup#MavenEcosystemCleanup-ResolverandMaven
##########
File path: pom.xml
##########
@@ -170,7 +145,13 @@
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
- <version>4.13.1</version>
+ <version>4.13.2</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-simple</artifactId>
+ <version>1.7.32</version>
Review comment:
These are all "test" scoped deps, so they matter "locally" only, so IMHO
does not matter. We can align them (by same logic as resolver, so "use version
maven X used"), but putting them into parent is overkill IMO.
##########
File path:
src/main/java/org/apache/maven/reporting/exec/DefaultMavenPluginManagerHelper.java
##########
@@ -48,134 +50,20 @@
@Requirement
protected MavenPluginManager mavenPluginManager;
Review comment:
I wanted to keep changes focused (drop sonatype aether). I would rather
do a second PR that does plexus -> ATInject move...
##########
File path:
src/main/java/org/apache/maven/reporting/exec/DefaultMavenPluginManagerHelper.java
##########
@@ -34,6 +32,10 @@
import org.codehaus.plexus.component.annotations.Component;
import org.codehaus.plexus.component.annotations.Requirement;
import org.codehaus.plexus.logging.Logger;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.graph.DependencyFilter;
+import org.eclipse.aether.repository.RemoteRepository;
+import org.eclipse.aether.util.filter.ExclusionsDependencyFilter;
Review comment:
Yes, let's collect "missing APIs", agreed.
OTOH, this PR is to "up component maven dep to maven 3.2.x", that does not
provide those.
IMHO, we could start collecting and providing them in Maven 4.x line (or
even maybe Maven 3.9.x line), and when we start doing plugins 4.x line (like we
did with plugins 3.x that were aligned with Maven 3.x), then we could move all
plugins to newly published APIs...
Created page
https://cwiki.apache.org/confluence/display/MAVEN/Maven+Missing+APIs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
