imonteroperez edited a comment on pull request #440: URL: https://github.com/apache/maven-surefire/pull/440#issuecomment-1021973196
> Hi @imonteroperez ;-) Yes of course we will use your ITs. I am glad that you have joined us again! We also need to have updates of the documentation (Javadoc) of the config parameters. Do you have it as well in your commits? Can we use it? Hi @Tibor17 sorry for the late response, I got infected by COVID last week. I did not perform any update on Javadoc in https://github.com/apache/maven-surefire/pull/400/, so feel free to update this yourself. Only commit that you can use is the one about the ITs that I was mentioning in the previous comment. I saw that you updated the `negativeTest` but I would recommend also to include a new one to test the method filtering by itself. Something like: ``` public void shouldNotRunExcludedTestMethodByExcludesFile() { assumeThat( getSettings().getConfiguration(), is( INCLUDES_EXCLUDES_FILE ) ); String pattern = "!TestFive#testSuccessOne+testSuccessThree"; prepare( pattern ) .executeTest() .verifyErrorFree( 1 ) .verifyErrorFreeLog(); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
