slawekjaranowski commented on a change in pull request #440:
URL: https://github.com/apache/maven-surefire/pull/440#discussion_r783682775
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -2289,16 +2321,13 @@ private void maybeAppendList( List<String> base,
List<String> list )
private void checkMethodFilterInIncludesExcludes( Iterable<String>
patterns )
throws MojoFailureException
{
- if ( patterns != null )
+ for ( String pattern : patterns )
{
- for ( String pattern : patterns )
+ if ( pattern != null && pattern.contains( "#" ) )
{
- if ( pattern != null && pattern.contains( "#" ) )
- {
- throw new MojoFailureException( "Method filter prohibited
in "
- +
"includes|excludes|includesFile|excludesFile parameter: "
- + pattern );
- }
+ throw new MojoFailureException( "Method filter prohibited in "
+ + "includes|excludes|includesFile|excludesFile parameter: "
Review comment:
`includesFile|excludesFile` should not be supported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
