Tibor17 commented on a change in pull request #449:
URL: https://github.com/apache/maven-surefire/pull/449#discussion_r793090907
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/surefire/providerapi/ProviderDetector.java
##########
@@ -48,33 +51,35 @@
@Nonnull
public List<ProviderInfo> resolve( ConfigurableProviderInfo
dynamicProvider, ProviderInfo... wellKnownProviders )
{
- List<ProviderInfo> providersToRun = new ArrayList<>();
Set<String> manuallyConfiguredProviders =
getManuallyConfiguredProviders();
- for ( String name : manuallyConfiguredProviders )
+
+ List<ProviderInfo> providersToRun =
manuallyConfiguredProviders.stream()
+ .map( name -> findByName( name, dynamicProvider,
wellKnownProviders ) )
+ .collect( Collectors.toList() );
+
+
+ if ( providersToRun.isEmpty() )
{
- ProviderInfo wellKnown = findByName( name, wellKnownProviders );
- ProviderInfo providerToAdd = wellKnown != null ? wellKnown :
dynamicProvider.instantiate( name );
- logger.info( "Using configured provider " +
providerToAdd.getProviderName() );
- providersToRun.add( providerToAdd );
+ return autoDetectOneWellKnownProvider( wellKnownProviders )
+ .map( Collections::singletonList )
+ .orElse( Collections.emptyList() );
+ }
+ else
+ {
+ providersToRun.forEach( p -> logger.info( "Using configured
provider " + p.getProviderName() ) );
Review comment:
This logger should be called between the lines 57 and 58.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
