Tibor17 commented on a change in pull request #475:
URL: https://github.com/apache/maven-surefire/pull/475#discussion_r814074238
##########
File path:
surefire-api/src/main/java/org/apache/maven/surefire/api/booter/ForkingRunListener.java
##########
@@ -68,7 +68,7 @@ public void testSetStarting( TestSetReportEntry report )
@Override
public void testSetCompleted( TestSetReportEntry report )
{
- target.systemProperties( report.getSystemProperties() );
+ target.systemProperties( report.getSystemProperties(), null, null );
Review comment:
The `target` is not JUnit's RunListener implementation.
Only the framework's listener may have this data `runMode` and be "stateful".
The `target` is a pure encoder, and so it should not have any notion about
stateful data regarding test status. It should only receive data, encode it,
and send to a channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
