imonteroperez commented on pull request #440: URL: https://github.com/apache/maven-surefire/pull/440#issuecomment-1060903758
Sorry for being late in this discussion. Not sure to follow your concerns/ statements @Tibor17 > The implementation of tests that @imonteroperez was made in a wrong module. Many contributors have made the unit tests in right module I asked about it on https://github.com/apache/maven-surefire/pull/460#issuecomment-1048294455 and the only answer I got was https://github.com/apache/maven-surefire/pull/460#issuecomment-1053984089. I assumed based on your latest comment that everything was ok from your side and you will cherry-pick my changes here (in order to prevent who is the author of the changes) > @olamy as a speaker of @imonteroperez requires opposite which was never seen before and this attitude postpones the release No idea about previous releases or discussions around this topic (or whatever) _BUT_ (1) @olamy is not my speaker (2) I would say exactly the same that he said in terms of respect contributors credit in whatever project. As mentioned in https://github.com/apache/maven-surefire/pull/440#issuecomment-1057839316, I'm confused about this situation. > I made everything with Slawomir and we need to understand @olamy that we need to reach the consensus Yes, it seems you took my code from `SurefirePluginTest` https://github.com/apache/maven-surefire/pull/460/commits/1b721a9ee9d35997fe62376257577d92ddbd968a and moved it inside a different test/module. It is ok, _BUT_ I would prefer to get an answer when I asked about it as mentioned before. Given said that, please feel free to do whatever you want with this. I will let you decide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
