[GitHub] [maven-surefire] olamy commented on a change in pull request #478: [SUREFIRE-1426] Fork crash doesn't fail build with -Dmaven.test.failure.ignore=true

[GitBox]

olamy commented on a change in pull request #478:
URL: https://github.com/apache/maven-surefire/pull/478#discussion_r821314009



##########
File path: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java
##########
@@ -154,7 +155,11 @@ public static void reportExecution( 
SurefireReportParameters reportParameters, R
             return;
         }
 
-        if ( reportParameters.isTestFailureIgnore() )
+        if ( firstForkException instanceof SurefireBooterForkException )
+        {
+            throwException( reportParameters, result, firstForkException );

Review comment:
       both exception generate `BUILD FAILURE` at the end (probably a maven 
core bug)
   but anyway we need a build stop no need of a distinction really.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org