Tibor17 commented on a change in pull request #478:
URL: https://github.com/apache/maven-surefire/pull/478#discussion_r820982701
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java
##########
@@ -154,7 +155,11 @@ public static void reportExecution(
SurefireReportParameters reportParameters, R
return;
}
- if ( reportParameters.isTestFailureIgnore() )
+ if ( firstForkException instanceof SurefireBooterForkException )
+ {
+ throwException( reportParameters, result, firstForkException );
Review comment:
`throwException()` has two behaviors. You do not have possibility to
switch between them. Here must be only one behavior, means `BUILD ERROR` and
not `BUILD FAILURE`. I know that you saw my code proposal but you should think
about it. This situation is the same situation with the existing situation
`isFatal()` that we use nearby in this class. I think you want to have this
change because it is an exception in the behavior of
`-Dmaven.test.failure.ignore` which is okay if you ensure that `BUILD ERROR`
happens with `SurefireBooterForkException` is caught.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
