roxspring commented on a change in pull request #485:
URL: https://github.com/apache/maven-surefire/pull/485#discussion_r823154993



##########
File path: 
surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1787JUnit5IT.java
##########
@@ -93,6 +93,18 @@ public void selectJUnit5()
                 "Using auto detected provider 
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider" );
     }
 
+    @Test
+    public void selectJUnit5UsingConfiguredProvider()

Review comment:
       Fair enough. I've opened a separate 
https://issues.apache.org/jira/browse/SUREFIRE-2036 since the original 
regression still exists, and reworked this PR against that issue: 
e898f07ebe7e5ce29f6bf2c6070ed28370c95805

##########
File path: 
surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1787JUnit5IT.java
##########
@@ -93,6 +93,18 @@ public void selectJUnit5()
                 "Using auto detected provider 
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider" );
     }
 
+    @Test
+    public void selectJUnit5UsingConfiguredProvider()
+    {
+        unpack( "junit-4-5" )

Review comment:
       Done: e898f07ebe7e5ce29f6bf2c6070ed28370c95805




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to