gnodet edited a comment on pull request #690:
URL: https://github.com/apache/maven/pull/690#issuecomment-1064264508


   I've added a commit to revert 
https://github.com/apache/maven/commit/e327be3d85918a23a5ba48d752143a6dbf8b83f7 
because it's useless.
   
   This restores the  behavior from 3.8.4 when extensions are defined in the 
root pom and allows supporting the maven-build-cache-extension use case at 
https://github.com/apache/maven-build-cache-extension/pull/8.  This would break 
builds that would define extensions in the parent and in a child and expect 
them to be available later in the build.  If we want to completely restore the 
3.8.4 behavior, I can remove line 
https://github.com/apache/maven/pull/690/files#diff-7698873d65eece16fdf2ba67293827f623994a3affa509b814eaf33abb4537daR84
 so that the _last_ project with extensions wins.
   
   I agree this is not perfect and we should better support defining build 
extensions throughout the various projects in the reactor.  Such use cases are 
clearly not well covered, especially inheritance between parent/child projects, 
ordering, concurrency, etc...
   
   @michael-o @laeubi I'm willing to write an IT, but I can't write until we 
agree on the behavior...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to