crizzis commented on a change in pull request #487:
URL: https://github.com/apache/maven-surefire/pull/487#discussion_r824920327
##########
File path:
surefire-api/src/main/java/org/apache/maven/surefire/api/testset/TestListResolver.java
##########
@@ -195,13 +195,13 @@ public boolean shouldRun( Class<?> testClass, String
methodName )
/**
* Returns {@code true} if satisfies {@code testClassFile} and {@code
methodName} filter.
*
- * @param testClassFile format must be e.g. "my/package/MyTest.class"
including class extension; or null
- * @param methodName real test-method name; or null
+ * @param containerName format must be e.g. "my/package/MyTest.class"
including class extension; or null
Review comment:
The attribute names of this method have been changed to reflect their
new meaning. The second parameter to this method, for instance, will no longer
only ever represent method names. That's the entire purpose of this PR.
Would you care to explain why you would expect the parameters to retain
their original names?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
