Tibor17 commented on a change in pull request #487:
URL: https://github.com/apache/maven-surefire/pull/487#discussion_r824635901



##########
File path: surefire-providers/surefire-junit-platform/pom.xml
##########
@@ -136,6 +136,47 @@
                     </includes>
                 </configuration>
             </plugin>
+            <plugin>
+              <groupId>org.apache.maven.plugins</groupId>
+              <artifactId>maven-jar-plugin</artifactId>
+              <executions>
+                <execution>
+                  <id>api-jar</id>
+                  <phase>package</phase>
+                  <goals>
+                    <goal>jar</goal>
+                  </goals>
+                  <configuration>
+                    <classifier>api</classifier>

Review comment:
       There are other two SPI modules `surefire-extensions-spi` (for the 
forked JVM) and `surefire-extensions-api` (for the plugin process) but nothing 
is suited for this scenario of providers.
   Can you explain how the customer would implement the interface 
`TestSelectorFactory` you have introduced? What types of sources can be 
filtered and how they can be configured?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to