[ 
https://issues.apache.org/jira/browse/MPLUGIN-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505064#comment-17505064
 ] 

ASF GitHub Bot commented on MPLUGIN-394:
----------------------------------------

michael-o commented on a change in pull request #73:
URL: https://github.com/apache/maven-plugin-tools/pull/73#discussion_r824972534



##########
File path: 
maven-plugin-plugin/src/it/mplugin-394_report-encoding/invoker.properties
##########
@@ -0,0 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+# 
+#   http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+invoker.goals = -Dfile.encoding=CP1252 plugin:report

Review comment:
       @SebastianKuehn Please add a followup PR which documents the limitations 
of this PR




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Report-Mojo doesn't respect input encoding
> ------------------------------------------
>
>                 Key: MPLUGIN-394
>                 URL: https://issues.apache.org/jira/browse/MPLUGIN-394
>             Project: Maven Plugin Tools
>          Issue Type: Bug
>          Components: Plugin Plugin
>    Affects Versions: 3.6.4
>            Reporter: Sebastian Kühn
>            Assignee: Herve Boutemy
>            Priority: Major
>             Fix For: 3.7.0
>
>
> {{plugin:report}} reads the Plugin-XML-File with with the platform encoding 
> instead of the specified input encoding. This results in an broken generated 
> XDoc and finally Site.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to